Merge pull request #799 from dennis531/presenter-filter

Fix empty presenters filter field in events
opencast · Jul 9, 2024 · abcf6c5 · abcf6c5
2 parents 9f829e5 + 3c77010
commit abcf6c5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/src/components/shared/TableFilters.tsx b/src/components/shared/TableFilters.tsx
@@ -231,7 +231,7 @@ const TableFilters = ({
 // @ts-expect-error TS(7006): Parameter 'filter' implicitly has an 'any' type.
 	const renderBlueBox = (filter) => {
 // @ts-expect-error TS(7006): Parameter 'opt' implicitly has an 'any' type.
-		let valueLabel = filter.options.find((opt) => opt.value === filter.value)
+		let valueLabel = filter.options?.find((opt) => opt.value === filter.value)
 			?.label || filter.value;
 		return (
 			<span>
@@ -336,9 +336,7 @@ const TableFilters = ({
 										<span>
 											{
 												// Use different representation of name and value depending on type of filter
-												filter.type === "select" ? (
-													renderBlueBox(filter)
-												) : filter.type === "period" ? (
+												filter.type === "period" ? (
 													<span>
 														<span>
 															{t(filter.label).substr(0, 40)}:
@@ -351,7 +349,9 @@ const TableFilters = ({
 															})}
 														</span>
 													</span>
-												) : null
+												) : (
+													renderBlueBox(filter)
+												)
 											}
 										</span>
 										{/* Remove icon in blue area around filter */}

diff --git a/src/slices/tableFilterSlice.ts b/src/slices/tableFilterSlice.ts
@@ -79,7 +79,11 @@ export const fetchFilters = createAppAsyncThunk('tableFilters/fetchFilters', asy
 	});
 
 	if (resource === "events") {
-		filtersList.push({ name: "presentersBibliographic" });
+		filtersList.push({
+			label: "FILTERS.EVENTS.PRESENTERS_BIBLIOGRAPHIC.LABEL",
+			name: "presentersBibliographic",
+			translatable: false
+		});
 	}
 
 	return { filtersList, resource };