Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy roles matching pattern using External API #25

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pawohl
Copy link

@pawohl pawohl commented Feb 8, 2020

  • This PR adds a new directory external-api-ecma-script containing ECMA script
  • Amends the .travis-ci configuration to lint the code of the newly added external-api-ecma-script
  • Adds a script in external-api-ecma-script/src that helps with copying ACL roles to new rules. There is plenty of documentation in the script itself.

@pawohl pawohl requested a review from lkiesow February 8, 2020 14:29
@gregorydlogan
Copy link
Member

I'm unfamiliar with setting up ILIAS, is this something that every adopter who's using it will run into?

@lkiesow
Copy link
Member

lkiesow commented May 14, 2020

No, since there are multiple ways of integrating Opencast in ILIAS.

@pawohl, I know it's documented in the JS file but if you browse through the folders on GitHub it would be really helpful to have the description in the README.md file of that folder. Also, please use a name describing what this script does instead of a very generic name like external-api-ecma-script. If people are looking for a script, most won't care which programming language has been used. They need to know what it does.

also some minor documentation fixes within the script
@Rillke
Copy link
Member

Rillke commented May 18, 2020

@lkiesow Thanks for the review. Your concerns have been addressed and the requested amendments have been made. CI for the script passes.

@Rillke
Copy link
Member

Rillke commented May 18, 2020

I'm unfamiliar with setting up ILIAS, is this something that every adopter who's using it will run into?

It is required, for instance, if you change or set org.opencastproject.security.custom.roles.pattern after you had an ugly patch in your code that basically did the same but you had to compile and patch Opencast in order to do this and wanted to get rid of it ;-)

A more likely use case:
Some org will set up a second ILIAS instance and they want to change the prefix of existing ACLs from ILIAS_ to ILIAS1_ so they can distinguish ACLs for those 2 installations.

@gregorydlogan
Copy link
Member

@lkiesow is this something that can/should move forward, 4 years later :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants