Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return unknown for un-issued certificates. #2

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

vtsingaras
Copy link
Contributor

CA/B Forum guideline v1.1.9 (since v1.0.3) Section 13.2.6 demands that an OCSP responder should not return GOOD to a request about an unrecognized serial. This patch implements that by logging the unknown serial and returning UNKNOWN to the client. The serials are provided by a file that is specified in the CA configuration. A timeout option is supplied to reload the file each 'timeout' seconds. The serials file must be in the OpenSSL CA Database format (index.txt).

Vyronas Tsingaras added 5 commits September 19, 2014 16:36
@vtsingaras vtsingaras force-pushed the unknown-serial-status branch from 3cfdfe6 to 7bf502a Compare October 19, 2014 06:55
@opencrypto
Copy link
Member

Thanks for submitting the request. However, I am still investigating the security concerns (as per my e-mail on the mailing list). I am waiting for some replies from the PKIX mailing list about my concerns. If the security and deployment considerations will be addressed, we might add support for it and add the appropriate configuration options for enabling/disabling this mode.

@vtsingaras
Copy link
Contributor Author

I should note that this patch relies on my other pull request for libPKI here: openca/libpki#3

Also I'll rework the patch to handle index.txt reloading via a signal (eg. SIGUSR1) so don't just merge it yet.

@opencrypto
Copy link
Member

Ok.

Don't worry, I will review the patch before merging to be sure there are
no additional changes other than the memory fix :)

Cheers,
Max

On 11/13/14, 8:03 PM, Vyronas Tsingaras wrote:

I should note that this patch relies on my other pull request for
libPKI here: openca/libpki#3 openca/libpki#3

Also I'll rework the patch to handle index.txt reloading via a signal
(eg. SIGUSR1) so don't just merge it yet.


Reply to this email directly or view it on GitHub
#2 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants