-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore Github Actions for CI and build #114
Conversation
The goal for this job is to run the unit tests, so rename it to match this intention
@mlandauer Did you know Github has an inbuilt workflow feature now? It looks like we have ~10k minutes/month of free usage because of our account type. |
This will allow the CI system to run all the other tests usefully. `make integration` is available for circumstances where we still want to run the full suite including integration tests.
34b0302
to
e57712d
Compare
This reverts commit afb35e2.
i'm definitely happy to give github actions a try. :-) @jamezpolley do you want me to look at this? I see you've asked me to review this but it's not yet working as the tests are failing so I'm a little confused. |
Although Github Actions provides a Go action, that action doesn't set up the environment for use with Go. actions/setup-go#14 suggests that this is broken-as-intended. The two workarounds suggested there are using the Go container image to run tests; or to explicitly set up the environment like this.
Was just wanting to get initial feedback from you about whether this was worth going ahead with. |
I've now sorted out the last issue by explicitly setting $GOPATH as suggested in actions/setup-go#14 (comment) so that we can run the yinyo binary in the test |
thank you @jamezpolley! |
Possible partial implementation of #97