Skip to content
This repository has been archived by the owner on Feb 18, 2025. It is now read-only.

orchestrator-client gsed support for Darwin/BSD #795

Merged
merged 6 commits into from
Mar 24, 2019

Conversation

cswingler
Copy link
Contributor

Related issue: #794

Description

This PR adds in some logic in orchestrator-client to switch over to gsed if the system isn't guaranteed to have GNU coreutils installed.

Copy link
Collaborator

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Darwin guaranteed to have gsed installed?

@cswingler
Copy link
Contributor Author

It unfortunately is not, most people have it installed out of the gnu-sed package in Homebrew.

@shlomi-noach shlomi-noach merged commit 79e4ca4 into openark:master Mar 24, 2019
@shlomi-noach shlomi-noach mentioned this pull request Mar 24, 2019
@shlomi-noach
Copy link
Collaborator

This caused an infinite loop of sed function calling itself. Fixed via #848

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants