2 new variables #1463
Closed
2 new variables #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -98,6 +100,8 @@ function displayedDefaults (final_result) { | |||
| profile.offline_hotspot = allDefaults.offline_hotspot; | |||
| profile.edison_battery_shutdown_voltage = allDefaults.edison_battery_shutdown_voltage; | |||
| profile.pi_battery_shutdown_percent = allDefaults.pi_battery_shutdown_percent; | |||
| profile.threshold_setting = allDefaults.profile.threshold_setting; | |||
| profile.smb_delivery_ratio = allDefaults.smb_delivery_ratio; | |||
There was a problem hiding this comment.
These don't necessarily need to be displayedDefaults for rig users. I believe adding them to defaults above would be sufficient to allow iAPS to display them (or not) as y'all see fit?
Does anyone have an opinion on whether they should also be displayedDefaults for OpenAPS rig users? We generally have trie to avoid putting too many customizations "up front" for people to feel they should tweak them. Do the defaults here seem good enough for most users that these can be buried deeper to change if people really need to? Or do we need to make them more visible to encourage people to experiment with / tweak them?
In some places a space is used instead of a colon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has 2 objectives.
1: introduce 2 new variables.
2: This will make the Oref0 modules identical to the Oref0 code used in newest version of iAPS (v 4.0.0).Newest iAPS version 4 will be using clean Oref0 code.
Currently only difference is these 2 variables, in lib/determine_basal.js and lib/profile/index.js).
Variable 1: SMB Delivery Ratio.
Introduces a variable for the SMB Delivery Ratio, default is 0.5 (50 % of insulinReq) as before. Min/Max 0.1 to 1.
This has been a setting in iAPS for a long time and allows for adjustment by users of how rapid/slow the insulinReq is delivered. I use it mostly just in an iAPS middleware function, increasing the ratio slightly when glucose is quickly rising and/or decreasing when glucose is falling.
Variable 2: Minimum Glucose Threshold.
This variable allows to increase the very minimum glucose threshold of 65 mg/dl.
Some iAPS users think the the 65 mg/dl sometime is too low. This will allow users to increase this value. Default is 65, as before.