-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tzachi share node2 #1352
Tzachi share node2 #1352
Conversation
This saves initilaztion time. Worked for a day, which means testing only started.
starting it if needed.
Signed-off-by: Tzachi Dar <[email protected]>
@tzachi-dar Shouldn't this PR be for a merge on |
Sure, I have fixed this now. |
Is there any special installation required to use this? I'm getting failures using run_remote_command ns-status. It could also be due to merge conflicts with #1346 that I resolved incorrectly. Could you merge those two branches properly and push the results somewhere I can test them? |
I have merged both branches into #1359 |
Is this still needed, or is it superceded by #1370 ? |
I'm going to close this on the assumption it's no longer needed after #1370. If that's incorrect, we can reopen. |
This pr adds code to run on shared node.
Solution overview:
More details:
Keeping shared node alive:
Return value of shared node:
The result of the node consist of 3 things:
Testing:
Test rig has been looping for a long time without any problem. It was able to complete pump loops within 5 minutes except where communication with pump was problematic.
All input to the shared node is captured, and copied to a shared directory.
Later, the old code and the new code have been running on this input. No difference was found between the two runs.
With this change the rigs become much less loaded (and very likely this is also a needed step in reducing battery consumption).