Ignore glucose null #1324
Merged
Ignore glucose null #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danamlewis
approved these changes
Dec 4, 2019
|
I've been running this on a few of our rigs without regressions. Will merge soon for further testing if no further comments. |
| return obj; | ||
| if ( obj.glucose !== null ) { | ||
| return obj; | ||
| } |
There was a problem hiding this comment.
This will cause the map to return undefined instead of null values. If we first filter out those null values (via #1328) we can end up with a more concise array with only relevant values (no null or undefined).
What do you think?
There was a problem hiding this comment.
Ok, merged that. Null checks are still good, though, so any reason not to merge this too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a failed attempt to fix #1265, but would probably be a good idea regardless.