feat(openapi-fetch): add support for arbitrary method #2063
+50
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for openapi-ts canceled.
|
🦋 Changeset detectedLatest commit: f6a2db0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kerwanp
added
enhancement
kerwanp
force-pushed
the
feat/fetch-request
branch
2 times, most recently
from
53b3c32 to
2335067
Compare
drwpow
reviewed
Dec 21, 2024
kerwanp
force-pushed
the
feat/fetch-request
branch
from
2335067 to
f6a2db0
Compare
drwpow
approved these changes
Jan 3, 2025
Merged
|
FWIW: I've briefly checked whether it is worth backporting this to the path-based client and I believe for now it isn't: The API is lower-level than what the path-based client offers. So IMO it is unlikely someone would want the combination of path-based but arbitrary method. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This Pull request closes #1808 by providing a
requestmethod that accept a method as its first arguments allowing to pass anyHttpMethod. Making library authors' life easier.This does not introduce any breaking change.
How to Review
A new
requestshould be available on the client that must behave exactly like the otherGET,OPTIONS, etc methods but with the ability to pass the HttpMethod as first parameter.Checklist
docs/updated (if necessary)