fix(openapi-fetch): Prevent orphan ampersands in query from empty arr…

…ays (#1936)
openapi-ts · Oct 25, 2024 · d14aa65 · d14aa65
1 parent 2a0b0df
commit d14aa65
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 0 deletions.
diff --git a/.changeset/strong-boats-drive.md b/.changeset/strong-boats-drive.md
@@ -0,0 +1,5 @@
+---
+"openapi-fetch": patch
+---
+
+Fix multiple empty arrays in query params appending extra ampersands
diff --git a/packages/openapi-fetch/src/index.js b/packages/openapi-fetch/src/index.js
@@ -436,6 +436,9 @@ export function createQuerySerializer(options) {
           continue;
         }
         if (Array.isArray(value)) {
+          if (value.length === 0) {
+            continue;
+          }
           search.push(
             serializeArrayParam(name, value, {
               style: "form",

diff --git a/packages/openapi-fetch/test/common/params.test.ts b/packages/openapi-fetch/test/common/params.test.ts
@@ -264,6 +264,23 @@ describe("params", () => {
         expect(actualURL.search).toBe("");
       });
 
+      test("array params (empty, multiple)", async () => {
+        let actualURL = new URL("https://fakeurl.example");
+        const client = createObservedClient<paths>({}, async (req) => {
+          actualURL = new URL(req.url);
+          return Response.json({});
+        });
+
+        await client.GET("/query-params", {
+          params: {
+            query: { array: [], second_array: [], third_array: [] },
+          },
+        });
+
+        expect(actualURL.pathname).toBe("/query-params");
+        expect(actualURL.search).toBe("");
+      });
+
       test("empty/null params", async () => {
         let actualURL = new URL("https://fakeurl.example");
         const client = createObservedClient<paths>({}, async (req) => {