Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync navigation items (POIs / routes) (ambit2) - fixes #125 #128

Merged
merged 16 commits into from
Apr 4, 2017
Merged

Conversation

landas
Copy link
Member

@landas landas commented Apr 2, 2017

Summary

This pull request fixes #125 .

I have done extensive testing and I have never experienced any crashes on my computer or any problems on my Ambit. I have tested small routes, big routes, 1 route, many routes with a lot of data.

Waypoint / routepoint will sync if the user has enabled "sync logs with movescount". I will do some clean up in settings code after I have merged @superdupersvard code.

Known sources of uncertainty

How the ambit calculate the distance (this is an important part of sending routepoints to the device) is not 100% certain. I have used the standard Haversine formula and a earth radius of 6367km. This worked perfect in my tests of very long routes in south of Norway. I dont know if this is the correct formula used inside watch. I don't know if the watch use different earth radius on different points on the earth 😄

I need feed back from users to know. For me the formula and the erath radius work "perfect" within 5 meters error margin on a 200km route.

master...landas:master#diff-9b9ed44590de637db939610f2167c9ad

Some documentation on my research of the protocol

Ambit waypoints route documentation.zip

All the structs for sending data to the ambit is better documented in the code

master...landas:master#diff-88c7caf5ec8b5f03eba8965921806924

Last story

When developing and testing adding of routepoints, I had an error in my for loop so my code added routepoints-data way beyond the memory space for routepoints inside ambit. The result was it overwrite some of my sports mode with garbage data, but the ambit was all happy. It just reset itself to one default sport mode. 😄

So I think this watch is difficult to brick.

@manisandro manisandro requested review from paddy-hack and removed request for paddy-hack April 3, 2017 20:14
@manisandro
Copy link
Member

If this is deemed ready for merging I'm happy to do so.

@landas
Copy link
Member Author

landas commented Apr 4, 2017

I feel confident that this code can merge into the master now.
I'm happy to fix if anyone reports any problems.

After we have merged @superdupersvard and I have cleaned up some code in settings, maybe we should make it a new version and inform distributions to add the new version?

@manisandro manisandro merged commit 8082f29 into openambitproject:master Apr 4, 2017
@manisandro
Copy link
Member

Ok cool, thanks! Yeah sure it would be high time for a new version :)

@manisandro manisandro mentioned this pull request Apr 4, 2017
@mbernasocchi
Copy link
Member

great stuff guys :)

@vdca
Copy link

vdca commented Apr 5, 2019

Thanks for this great piece of software. I have haven't managed to get route-sync working with openambit 0.4 and an ambit3. Is this supposed to work only for routes created via movescount, or is it possible to write say a gpx file directly to the watch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync navigation items (POIs / routes) (ambit2)
4 participants