Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error when uploading existing log. #123

Merged
merged 1 commit into from
Mar 23, 2017
Merged

Fixed error when uploading existing log. #123

merged 1 commit into from
Mar 23, 2017

Conversation

landas
Copy link
Member

@landas landas commented Mar 23, 2017

This fix will allow openambit to update xml-file with MoveID even if log is uploaded with another client.
uiservices.movecounts.com return unknown content error when log i uploaded before.

@manisandro
Copy link
Member

So the log is uploaded correctly despite the server returning UnknownContentError?

@landas
Copy link
Member Author

landas commented Mar 23, 2017

Yes, the http-json-data is the same.

This is the error message it got before the fix (but with added status code):
Failed to upload log, movescount.com replied with " 299 "{"MoveID":80838519,"SelfURI":"moves/80838519"}" "''

Status code 299 = QNetworkReply::UnknownContentError

@manisandro manisandro merged commit b322597 into openambitproject:master Mar 23, 2017
@manisandro
Copy link
Member

Thanks

@landas
Copy link
Member Author

landas commented Mar 23, 2017

I will clearify my answer, since you asked "So the log is uploaded correctly...?"

The logs were allready uploaded from Windows moveslink2, so it did not create a new log/move on moveslink.com, but this code will update openambit log.xml files with correct MoveId, so it doesnt retry uploading old moves every time I open openambit, and i get a nice link to the moves :)

@manisandro
Copy link
Member

Ok thanks:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants