Improvements implemented in the audio processing module #2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrfelpa
commented
Oct 15, 2024
mrfelpa
commented
- The relative import causing errors when the script was executed directly, so I changed from .utils import exact_div to from utils import exact_div. I also implemented a function (get_hann_window) to avoid repeated Hann window calculations.
mrfelpa
commented
Oct 17, 2024
whisper/audio.py
Outdated
|
|
||
| log_spec = torch.clamp(mel_spec, min=1e-10).log10() | ||
|
|
||
| log_spec_normalized = (log_spec + 4.0) / 4.0 |
There was a problem hiding this comment.
@Nisarg236 I did it separately to try to keep the code clearer, but yes, it is possible to combine the two.
- I've implemented an update to the load_audio function to provide better control over the process, allowing for better error handling and resource management. Specifically, ffmpeg output streams are now explicitly handled, decoding errors are caught - I implemented a fix in the load_audio function, direct shell command execution (which can introduce vulnerabilities) has been avoided. The ffmpeg command now uses hide_banner to avoid displaying sensitive information. - Additional input validation checks were incorporated to verify function arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.