Move MuJoCo to extras_require #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah I think this is reasonable. @jachiam it looks like mujoco is really just a dependency on gym, right? |
|
LGTM! |
mahdinobar
pushed a commit
to mahdinobar/spinningup
that referenced
this pull request
Sep 26, 2024
Move MuJoCo to extras_require
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making MuJoCo optional install, as putting it in install_requires results in error for people who do not want MuJoCo
To install MuJoCo as well , use 'pip install -e .[mujoco]'
'pip install -e .' installs rest execpt mujoco