Address non-ASCII filename support for files, audio, etc. #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72.
The library's
multipart/form-data
implementation uses custom logic to bypass the use of thefilename*
Content-Disposition
parameter, which is RFC 6266's method of encoding non-ASCII filenames inmultipart/form-data
requests. This bypass was made in deference to an interpretation of RFC 7578 wherein the use offilename*
is disallowed.This PR removes the restriction by directly using
System.Net.Http.MultipartFormDataContent.Add()
'sfilename*
behavior.Although pending discussion with the Base Common Library team is still needed to clarify best interoperability practices, this is a better current state because:
System.Net.Http
filename*
parameter itself, but rather on the use of the encoding scheme of the newerfilename*
in the olderfilename
filename
intact for any unanticipated backwards compatibility issues with API gateways or other intermediaries