Support kwargs in gym.make and export register #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We avoided adding kwargs for a long time in order to encourage people to statically register their environment definitions. However, over time we've found a few important use-cases for kwargs, such as: - Runtime-specific objects, such as which GPU to run the environment on - Parametrized environments, which can have an infinite number of meaningful variants The latter breaks the invariant that the environment ID alone determines the semantics of the environment, but it's an advanced use-case and such users should be able to manage this on their own.
pzhokhov
approved these changes
Jan 29, 2019
joschu
approved these changes
Jan 29, 2019
kiku-jw
pushed a commit
to kiku-jw/gym
that referenced
this pull request
Feb 23, 2019
* Support kwargs in gym.make We avoided adding kwargs for a long time in order to encourage people to statically register their environment definitions. However, over time we've found a few important use-cases for kwargs, such as: - Runtime-specific objects, such as which GPU to run the environment on - Parametrized environments, which can have an infinite number of meaningful variants The latter breaks the invariant that the environment ID alone determines the semantics of the environment, but it's an advanced use-case and such users should be able to manage this on their own. * Export the register method so it's easier for external users to register environments * Improve kwargs test
Merged
zlig
pushed a commit
to zlig/gym
that referenced
this pull request
Apr 24, 2020
* Support kwargs in gym.make We avoided adding kwargs for a long time in order to encourage people to statically register their environment definitions. However, over time we've found a few important use-cases for kwargs, such as: - Runtime-specific objects, such as which GPU to run the environment on - Parametrized environments, which can have an infinite number of meaningful variants The latter breaks the invariant that the environment ID alone determines the semantics of the environment, but it's an advanced use-case and such users should be able to manage this on their own. * Export the register method so it's easier for external users to register environments * Improve kwargs test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We avoided adding kwargs for a long time in order to encourage people to statically register their environment definitions. However, over time we've found a few important use-cases for kwargs, such as:
The latter breaks the invariant that the environment ID alone determines the semantics of the environment, but it's an advanced use-case and such users should be able to manage this on their own.
This PR also exports the
registermethod so people can register their own environments more easily.