Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat-suse: use iftype in sysctl handling (bsc#1230911) #1043

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

cfconrad
Copy link
Collaborator

Fix loopback sysctl configuration. Since gh#openSUSE/open-build-service#895 sysctl settings
for loopback device where ignored. This is considered wrong as it fails to set disable_ipv6 properly.
On top we doesn't set the ipv6/ipv4 enabled node since gh#openSUSE/open-build-service#990 causing
lo to stay in device-not-running, with net.ipv6.conf.(all|default).disable_ipv6=1.

Fixes:

  • Always generate the ipv4/ipv6 <enabled>true|false</enabled> node
  • Inherit all,default,interface sysctl settings also for loopback,
    except for use_tempaddr and accept_dad sysctl's.
  • Consider only interface specific accept_redirects sysctl settings.
  • Adopt ifsysctl(5) manual page with wicked specific behavior.

The value depends on kernel cmdline disable_ipv6.
But the xml node should be always there.
Describe wicked sysctl processing and list all sysctl considered by
wicked.
* Inherit all,default,interface sysctl settings also for loopback,
  except for `use_tempaddr` and `accept_dad` sysctl's.
* Consider only interface specific `accept_redirects` sysctl settings.
@cfconrad cfconrad changed the title compat-suse: use iftype for specific sysctl handling compat-suse: use iftype for specific sysctl handling (bsc#1230911) Oct 25, 2024
@cfconrad cfconrad changed the title compat-suse: use iftype for specific sysctl handling (bsc#1230911) compat-suse: use iftype in sysctl handling (bsc#1230911) Oct 25, 2024
Copy link
Member

@mtomaschewski mtomaschewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we've already extensively tested and reviewed it before.

@mtomaschewski mtomaschewski merged commit 8b79f7f into openSUSE:master Oct 25, 2024
@cfconrad cfconrad mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants