Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes proposed by Korean translators #632

Closed
jfaltenbacher opened this issue Jun 25, 2024 · 4 comments
Closed

Changes proposed by Korean translators #632

jfaltenbacher opened this issue Jun 25, 2024 · 4 comments
Assignees
Labels
prio:high topic-l10n Localization issues

Comments

@jfaltenbacher
Copy link

Please apply the following changes to /usr/share/xml/docbook/stylesheet/suse2022-ns/common/l10n/ko.xml proposed by Korean translators:

  • The xref to Section is in Chinese. Please update this to 절.
  • Change all 項 into 절 globally.
  • In the context of <l:context name="xref-number"> change all occurrences of <l:template name="sect1" text="%n項"/> to <l:template name="sect1" text="%n절"/> (see lines 171-178)
@ptinley-vt
Copy link

Just to clarify... it is just one issue.
The reviewer reported that in this particular cross-ref format, the character displayed was actually a Chinese character (項).
This is how it was reported.
image

In lines 172-177 in /usr/share/xml/docbook/stylesheet/suse2022-ns/common/l10n/ko.xml need to have '%n&#38917;' changed to '%n절'. There are 6 occurrences; one for sect1, sect2, sect3, sect4, sect5 & section.

@tomschr tomschr added the topic-l10n Localization issues label Jan 7, 2025
@tomschr
Copy link
Collaborator

tomschr commented Feb 12, 2025

@jfaltenbacher I think I have some questions. 🙂

The xref to Section is in Chinese. Please update this to 절.

I can't read Chinese. 😉 Please point me to the right line.

Change all 項 into 절 globally.

項 = &#38917; => 절 = &#51208;

@ptinley-vt
Copy link

Does this information, given in the bug report above, make sense?

In lines 172-177 in /usr/share/xml/docbook/stylesheet/suse2022-ns/common/l10n/ko.xml need to have '%n項' changed to '%n절'. There are 6 occurrences; one for sect1, sect2, sect3, sect4, sect5 & section.

&#38917; is the incorrect character. (It's Chinese).
&#51208; is the correct Korean character.

Image

@tomschr
Copy link
Collaborator

tomschr commented Feb 13, 2025

@ptinley-vt Thanks Patrick, that helped! I changed the Korean file, but I'm not sure if this is correct. Could anybody have a quick look:

https://github.com/openSUSE/suse-xsl/pull/667/files

You can comment directly on the pull request.

tomschr added a commit that referenced this issue Feb 13, 2025
Fix #632: Changes proposed by Korean translators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio:high topic-l10n Localization issues
Projects
None yet
Development

No branches or pull requests

3 participants