Update TermwebProducts3rdParty.yml #123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexvonme
commented
Aug 18, 2024
| K\.D\.E\.|KDE Desktop Environment: KDE | ||
| Nvidia: NVIDIA | ||
| SUSE Linux Cloud|SUSE Cloud: SUSE OpenStack Cloud|SOC | ||
| shell tool|command line tool: command-line tool|CLT | ||
| xen|XEN: Xen | ||
| bug[- ]?buddy: bug-buddy | ||
| Kanidm: Kanidm | ||
| K\.?D\.?E\.?(?:\sDesktop\sEnvironment)?: KDE |
There was a problem hiding this comment.
The older version didn't correct K.D.E., meanwhile the new version corrects it to KDE.. I couldn't get rid of the final dot there.
alexvonme
commented
Aug 18, 2024
| K\.?D\.?E\.?(?:\sDesktop\sEnvironment)?: KDE | ||
| NVIDIA: NVIDIA | ||
| SUSE(?:\sLinux)? Cloud: SUSE OpenStack Cloud|SOC | ||
| shell tool|command[- ]?line tool: command-line tool|CLT |
There was a problem hiding this comment.
Command-Line Tool and clt are now accepted because of an issue with Vale, errata-ai/vale/issues/873. When a rule applies ignorecase:true, in swap options that include special characters, the corrections also become case insensitive.
I'll make changes, if necessary, when that issue is resolved.
There was a problem hiding this comment.
Just to clarify, I don't think this caveat is a major one. After we can improve the KDE. issue explained above, this pull request can be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've expanded the rule with
ignorecase:true. However, there are two small inefficiencies which I'll show with comments.