Let salt-ssh use 'platform-python' binary in RHEL8 #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meaksh
reviewed
Dec 3, 2019
salt/client/ssh/__init__.py
Outdated
| @@ -147,7 +147,7 @@ | |||
| then SUDO="sudo " | |||
| fi | |||
| EX_PYTHON_INVALID={EX_THIN_PYTHON_INVALID} | |||
| PYTHON_CMDS="python3 python27 python2.7 python26 python2.6 python2 python" | |||
| PYTHON_CMDS="python3 /usr/libexec/platform-python3.6 python27 python2.7 python26 python2.6 python2 python" | |||
There was a problem hiding this comment.
Just a minor question - why not doing it more generic? like:
Suggested change
| PYTHON_CMDS="python3 /usr/libexec/platform-python3.6 python27 python2.7 python26 python2.6 python2 python" | |
| PYTHON_CMDS="python3 /usr/libexec/platform-python python27 python2.7 python26 python2.6 python2 python" |
Would that work?
There was a problem hiding this comment.
if that work, I would move it to the end of the list, so in case that another python package is installed, that will be used
There was a problem hiding this comment.
well, python 3 should be prefered over python 2.
The code iterrate over the list and the first wins.
There was a problem hiding this comment.
@meaksh I wanted to explicitly add the version so the ordering is clear, but since it's not 3 but 3.6, I think your suggestion makes sense to future-proof this.
RHEL/CentOS 8 has an internal Python interpreter called 'platform-python' included in the base setup. Add this binary to the list of Python executables to look for when creating the sh shim.
meaksh
approved these changes
Dec 4, 2019
meaksh
pushed a commit
that referenced
this pull request
Dec 4, 2019
RHEL/CentOS 8 has an internal Python interpreter called 'platform-python' included in the base setup. Add this binary to the list of Python executables to look for when creating the sh shim.
meaksh
pushed a commit
that referenced
this pull request
Dec 4, 2019
RHEL/CentOS 8 has an internal Python interpreter called 'platform-python' included in the base setup. Add this binary to the list of Python executables to look for when creating the sh shim.
brejoc
pushed a commit
that referenced
this pull request
Jan 31, 2020
RHEL/CentOS 8 has an internal Python interpreter called 'platform-python' included in the base setup. Add this binary to the list of Python executables to look for when creating the sh shim.
meaksh
pushed a commit
that referenced
this pull request
Mar 10, 2020
RHEL/CentOS 8 has an internal Python interpreter called 'platform-python' included in the base setup. Add this binary to the list of Python executables to look for when creating the sh shim.
brejoc
pushed a commit
that referenced
this pull request
Mar 20, 2020
RHEL/CentOS 8 has an internal Python interpreter called 'platform-python' included in the base setup. Add this binary to the list of Python executables to look for when creating the sh shim.
meaksh
pushed a commit
that referenced
this pull request
Mar 23, 2020
RHEL/CentOS 8 has an internal Python interpreter called 'platform-python' included in the base setup. Add this binary to the list of Python executables to look for when creating the sh shim.
meaksh
pushed a commit
that referenced
this pull request
Mar 24, 2020
RHEL/CentOS 8 has an internal Python interpreter called 'platform-python' included in the base setup. Add this binary to the list of Python executables to look for when creating the sh shim.
brejoc
pushed a commit
that referenced
this pull request
Apr 8, 2020
RHEL/CentOS 8 has an internal Python interpreter called 'platform-python' included in the base setup. Add this binary to the list of Python executables to look for when creating the sh shim.
meaksh
pushed a commit
that referenced
this pull request
Apr 30, 2020
RHEL/CentOS 8 has an internal Python interpreter called 'platform-python' included in the base setup. Add this binary to the list of Python executables to look for when creating the sh shim.
meaksh
pushed a commit
that referenced
this pull request
May 20, 2020
RHEL/CentOS 8 has an internal Python interpreter called 'platform-python' included in the base setup. Add this binary to the list of Python executables to look for when creating the sh shim.
meaksh
pushed a commit
that referenced
this pull request
Sep 20, 2021
RHEL/CentOS 8 has an internal Python interpreter called 'platform-python' included in the base setup. Add this binary to the list of Python executables to look for when creating the sh shim.
meaksh
pushed a commit
that referenced
this pull request
Sep 23, 2021
RHEL/CentOS 8 has an internal Python interpreter called 'platform-python' included in the base setup. Add this binary to the list of Python executables to look for when creating the sh shim.
meaksh
pushed a commit
that referenced
this pull request
Sep 23, 2021
RHEL/CentOS 8 has an internal Python interpreter called 'platform-python' included in the base setup. Add this binary to the list of Python executables to look for when creating the sh shim.
agraul
pushed a commit
that referenced
this pull request
Jan 19, 2022
RHEL/CentOS 8 has an internal Python interpreter called 'platform-python' included in the base setup. Add this binary to the list of Python executables to look for when creating the sh shim.
agraul
pushed a commit
that referenced
this pull request
Jan 21, 2022
RHEL/CentOS 8 has an internal Python interpreter called 'platform-python' included in the base setup. Add this binary to the list of Python executables to look for when creating the sh shim.
agraul
pushed a commit
that referenced
this pull request
Jan 25, 2022
RHEL/CentOS 8 has an internal Python interpreter called 'platform-python' included in the base setup. Add this binary to the list of Python executables to look for when creating the sh shim.
meaksh
pushed a commit
that referenced
this pull request
Dec 28, 2022
RHEL/CentOS 8 has an internal Python interpreter called 'platform-python' included in the base setup. Add this binary to the list of Python executables to look for when creating the sh shim.
meaksh
pushed a commit
that referenced
this pull request
Dec 29, 2022
RHEL/CentOS 8 has an internal Python interpreter called 'platform-python' included in the base setup. Add this binary to the list of Python executables to look for when creating the sh shim.
meaksh
pushed a commit
that referenced
this pull request
Dec 29, 2022
RHEL/CentOS 8 has an internal Python interpreter called 'platform-python' included in the base setup. Add this binary to the list of Python executables to look for when creating the sh shim.
meaksh
pushed a commit
that referenced
this pull request
Mar 22, 2023
RHEL/CentOS 8 has an internal Python interpreter called 'platform-python' included in the base setup. Add this binary to the list of Python executables to look for when creating the sh shim.
meaksh
pushed a commit
that referenced
this pull request
Apr 10, 2023
RHEL/CentOS 8 has an internal Python interpreter called 'platform-python' included in the base setup. Add this binary to the list of Python executables to look for when creating the sh shim.
meaksh
pushed a commit
that referenced
this pull request
Apr 19, 2023
RHEL/CentOS 8 has an internal Python interpreter called 'platform-python' included in the base setup. Add this binary to the list of Python executables to look for when creating the sh shim.
meaksh
pushed a commit
that referenced
this pull request
Oct 29, 2024
RHEL/CentOS 8 has an internal Python interpreter called 'platform-python' included in the base setup. Add this binary to the list of Python executables to look for when creating the sh shim.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RHEL/CentOS 8 has an internal Python interpreter called 'platform-python'
included in the base setup.
Add this binary to the list of Python executables to look for when creating the sh shim.
What issues does this PR fix or reference?
Previous Behavior
In RHEL8,
salt-sshfailed unless Python is installed from the Python module.New Behavior
salt-sshworks with the baseplatform-pythonbinary.Tests written?
No
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.