Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest version of alacritty configuration. #88

Closed
wants to merge 0 commits into from
Closed

Update to the latest version of alacritty configuration. #88

wants to merge 0 commits into from

Conversation

mcepl
Copy link
Collaborator

@mcepl mcepl commented Jan 4, 2023

Replace background_opacity with window.opacity.

Copy link
Collaborator

@FilippoBonazziSUSE FilippoBonazziSUSE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcepl mcepl closed this Jan 9, 2023
@mcepl mcepl deleted the update_alacritty branch January 9, 2023 14:11
@denisok
Copy link
Contributor

denisok commented Jan 9, 2023

@mcepl looks like you deleted remote branch so changes are gone and PR is closed.

@mcepl
Copy link
Collaborator Author

mcepl commented Jan 9, 2023

@mcepl looks like you deleted remote branch so changes are gone and PR is closed.

Yes, because somebody obviously did the same what I did.

@FilippoBonazziSUSE
Copy link
Collaborator

We have several merged PRs now offering functionality that has never been released... what would it take to prepare a new release?

@denisok
Copy link
Contributor

denisok commented Jan 9, 2023

I tried to approach it sometime ago, but Sway build was broken and thus openSUSEway also was broken.

 Factory Maintainer wrote in package openSUSE:Factory/openSUSEway:

Installcheck problems for i586

    FOLLOWUP(openSUSEway)
    package openSUSEway-0.14.noarch requires sway-branding-openSUSE, but none of the providers can be installed
    package openSUSEway-0.14.noarch requires waybar-branding-openSUSE, but none of the providers can be installed
    package patterns-sway-sway-20200619.i586 requires waybar, but none of the providers can be installed
    package sway-branding-openSUSE-0.14.noarch requires patterns-sway-sway, but none of the providers can be installed
    package waybar-0.9.16.i586 requires waybar-branding = 0.9.16, but none of the providers can be installed
    package waybar-branding-openSUSE-0.14.noarch conflicts with namespace:otherproviders(waybar-branding) provided by waybar-branding-upstream-0.9.16.noarch
    package waybar-branding-upstream-0.9.16.noarch conflicts with waybar-branding provided by waybar-branding-openSUSE-0.14.noarch

Installcheck problems for x86_64

    FOLLOWUP(openSUSEway)
    package openSUSEway-0.14.noarch requires sway-branding-openSUSE, but none of the providers can be installed
    package openSUSEway-0.14.noarch requires waybar-branding-openSUSE, but none of the providers can be installed
    package patterns-sway-sway-20200619.x86_64 requires waybar, but none of the providers can be installed
    package sway-branding-openSUSE-0.14.noarch requires patterns-sway-sway, but none of the providers can be installed
    package waybar-0.9.16.x86_64 requires waybar-branding = 0.9.16, but none of the providers can be installed
    package waybar-branding-openSUSE-0.14.noarch conflicts with namespace:otherproviders(waybar-branding) provided by waybar-branding-upstream-0.9.16.noarch
    package waybar-branding-upstream-0.9.16.noarch conflicts with waybar-branding provided by waybar-branding-openSUSE-0.14.noarch

Now it is fixed with new Sway release. I would try to allocate some time to make a release.

And don't hesitate to make a new release. I either could grant some permissions, or could push a button to release. Package update - almost anyone could do that on OBS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants