Margin and padding shim for bootstrap 5 migration #13625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellcp-work
changed the title
dmarcoux
reviewed
Jan 4, 2023
| $infix: breakpoint-infix($breakpoint, $grid-breakpoints); | ||
|
|
||
| @each $prop, $abbrev in (margin: m, padding: p) { | ||
| @each $size, $length in $spacers { |
dmarcoux
reviewed
Jan 4, 2023
| @@ -0,0 +1,16 @@ | |||
| @each $breakpoint in map-keys($grid-breakpoints) { | |||
| @include media-breakpoint-up($breakpoint) { | |||
| $infix: breakpoint-infix($breakpoint, $grid-breakpoints); | |||
There was a problem hiding this comment.
breakpoint-infix is defined upstream in Bootstrap.
|
In the commits, it would be nice to link to the Bootstrap documentation where those changes are mentioned: https://getbootstrap.com/docs/5.0/migration/#utilities |
dmarcoux
reviewed
Jan 4, 2023
| @@ -0,0 +1,16 @@ | |||
| @each $breakpoint in map-keys($grid-breakpoints) { | |||
There was a problem hiding this comment.
How did you come up with this Sass code? It looks like something from upstream which was slightly adapted. I'm asking to understand and also to compare with how Bootstrap does this.
There was a problem hiding this comment.
Indeed I just copied over code from https://github.com/twbs/bootstrap/blob/v4-dev/scss/utilities/_spacing.scss and modified it to replace r and l to e and s
hellcp-work
force-pushed
the
bs5-margin
branch
from
55ce1e2
to
78f12d7
Compare
|
This PR will need to be rebased to fix conflicts. |
hellcp-work
force-pushed
the
bs5-margin
branch
5 times, most recently
from
cb44445
to
f387ce7
Compare
hellcp-work
force-pushed
the
bs5-margin
branch
from
f387ce7
to
c0c2924
Compare
eduardoj
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of #13602, updating all existing margin and padding to use s and e instead of l and r