build-recipe-livebuild: run as root with 'sh -c' instead of 'su -c ... - root' #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -193,9 +193,9 @@ recipe_build_livebuild() { | |||
|
|
|||
| if [ -x $BUILD_ROOT/usr/lib/build/livebuild_pre_run ] ; then | |||
| echo "Running OBS build livebuild_pre_run hook" | |||
| chroot $BUILD_ROOT su -c \ | |||
| chroot $BUILD_ROOT sh -c \ | |||
| "export RECIPEFILE=${RECIPEFILE}; /usr/lib/build/livebuild_pre_run" \ | |||
There was a problem hiding this comment.
and in the next lines;)
There was a problem hiding this comment.
Here and below it's running a shell line, not a single command (eg, export or change directory, then run thing), so I don't think I can for this one
…. - root' livebuild stopped working some time ago: [ 48s] ----------------------------------------------------------------- [ 48s] ----- building standard.livebuild (user abuild) [ 48s] ----------------------------------------------------------------- [ 48s] ----------------------------------------------------------------- [ 49s] su: Critical error - immediate abort [ 50s] su: Critical error - immediate abort https://build.opensuse.org/package/live_build_log/home:bluca:debian_secure_boot/example-images/img_nokernel/x86_64 Run it as root instead of abuild like other image build systems, and use sh -c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
livebuild stopped working some time ago:
[ 48s] -----------------------------------------------------------------
[ 48s] ----- building standard.livebuild (user abuild)
[ 48s] -----------------------------------------------------------------
[ 48s] -----------------------------------------------------------------
[ 49s] su: Critical error - immediate abort
[ 50s] su: Critical error - immediate abort
https://build.opensuse.org/package/live_build_log/home:bluca:debian_secure_boot/example-images/img_nokernel/x86_64
Run it as root instead of abuild like other image build systems, and use sh -c.