Avoid copying the user setup script with 'podman cp' #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We needed to copy the setup script (for user toolboxes), when they were generated in /tmp on the host. But they're currently generated directly in $HOME, and since we bind mount $HOME... well, it's just already there (and one can even argue that it's a bug copying it!). So, not copying is the right thing do to and, nicely enough, it also workarounds what apparently is a podman 3 issue with 'podman cp', basically fixing issue openSUSE#25 too. While there, add cleanup logic for the same user setup script. In fact, if everything goes fine, the script is removed by the toolbox itself (after executing it). But if there's an error and we bail, it may stick around, cluttering the home directory. Signed-off-by: Dario Faggioli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed to copy the setup script (for user toolboxes), when they were
generated in /tmp on the host. But they're currently generated directly
in $HOME, and since we bind mount $HOME... well, it's just already
there (and one can even argue that it's a bug copying it!).
So, not copying is the right thing do to and, nicely enough, it also
workarounds what apparently is a podman 3 issue with 'podman cp',
basically fixing issue #25 too.
While there, add cleanup logic for the same user setup script. In fact,
if everything goes fine, the script is removed by the toolbox itself
(after executing it). But if there's an error and we bail, it may stick
around, cluttering the home directory.
Signed-off-by: Dario Faggioli [email protected]