Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should catatonit rewrite LISTEN_PID? #13

Closed
alexlarsson opened this issue Sep 2, 2021 · 0 comments · Fixed by #15
Closed

Should catatonit rewrite LISTEN_PID? #13

alexlarsson opened this issue Sep 2, 2021 · 0 comments · Fixed by #15

Comments

@alexlarsson
Copy link

podman (as per containers/podman#11316 at least) rewrites LISTEN_PID in socket-activated services to 1. However if using --init with catatonit this is not the right value, it should be 2. Its unclear if podman is responsible for making LISTEN_PID 2, or it catatonit should do the rewrite. However, no matter what podman does, it is safe for catatonit to rewrite LISTEN_PID=1.
giuseppe added a commit to giuseppe/catatonit that referenced this issue Sep 2, 2021
@giuseppe
catatoinit: rewrite LISTEN_PID to the child process
75b9133 
In order to get systemd fd passing let's rewrite the LISTEN_PID
environment variable if it is pointing to catatonit init process.

Closes: openSUSE#13

Signed-off-by: Giuseppe Scrivano <[email protected]>
@giuseppe giuseppe mentioned this issue Sep 2, 2021
Merged
@cyphar cyphar closed this as completed in 0de094f Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

catatoinit: rewrite LISTEN_PID to the child process giuseppe/catatonit
1 participant
@alexlarsson