Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix structure.h5: Patches Metadata #23

Open
wants to merge 1 commit into
base: draft
Choose a base branch
from

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Apr 17, 2024

The particle patches lacked the unitDimension metadata attribute. This fixes it.

X-ref: openPMD/openPMD-validator#75

Follow-up to #22

The particle patches lacked the `unitDimension` metadata attribute.
This fixes it.
Copy link
Member

@s-sajid-ali s-sajid-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that this file does not crash with the existing openpmd-ls (prior to fix in the openpmd-api repository).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants