Particle Patches: Do not emplace patch records if they don't exist in the file being read #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
ax3l
approved these changes
Mar 17, 2021
ax3l
pushed a commit
to ax3l/openPMD-api
that referenced
this pull request
Apr 9, 2021
… the file being read (openPMD#945) * Removed from PR during backport: Test openpmd-pipe on git-sample/data%T.h5 * Only emplace particle patches in container if they exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GenerationPolicyforParticleSpeciesautomatically fills theparticlePatchescontainer with thenumParticlesandnumParticlesOffsetcomponents, meaning that a reading code has no way to know whether those records actually exist. This resulted in theopenpmd-pipetool failing to convert a dataset containing a particle species without patches (with extremely cryptic error messages from somewhere deep in the backend). This PR adds (1) a failing test and (2) a fix.