C++14 #825
Merged
C++14 #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
force-pushed
the
topic-cxx14
branch
3 times, most recently
from
a753dba to
39a920d
Compare
ax3l
force-pushed
the
topic-cxx14
branch
3 times, most recently
from
fdc76b7 to
af509d7
Compare
Try to address:
```
In file included from /home/runner/work/openPMD-api/openPMD-api/include/openPMD/binding/python/Variant.hpp:26:0,
from /home/runner/work/openPMD-api/openPMD-api/include/openPMD/binding/python/Numpy.hpp:24,
from /home/runner/work/openPMD-api/openPMD-api/src/binding/python/Attributable.cpp:24:
/home/runner/work/openPMD-api/openPMD-api/share/openPMD/thirdParty/pybind11/include/pybind11/stl.h: In instantiation of ‘static pybind11::handle pybind11::detail::variant_caster<V<Ts ...> >::cast(Variant&&, pybind11::return_value_policy, pybind11::handle) [with Variant = mpark::variant ...
/home/runner/work/openPMD-api/openPMD-api/src/binding/python/Attributable.cpp:337:10: required from here
/home/runner/work/openPMD-api/openPMD-api/share/openPMD/thirdParty/pybind11/include/pybind11/stl.h:362:37: error: no matching function for call to ‘pybind11::detail::visit_helper<mpark::variant>::call(pybind11::detail::variant_caster_visitor, mpark::variant<
```
Too old for multi-return statements in constexpr functions: MSVC++ 14.0, _MSC_VER == 1900 (Visual Studio 2015 version 14.0) New enough: MSVC++ 14.1, _MSC_VER == 1910 (Visual Studio 2017 version 15.0)
ax3l
force-pushed
the
topic-cxx14
branch
2 times, most recently
from
b5c1888 to
0999e0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require C++14 or newer.