Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPark.Variant #74

Merged
merged 6 commits into from
Feb 16, 2018
Merged

MPark.Variant #74

merged 6 commits into from
Feb 16, 2018

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Feb 16, 2018 •
edited
Loading

Draft for removing boost::variant for a std::variant in from MPark.Variant #70

@ax3l ax3l requested a review from C0nsultant February 16, 2018 12:56
@ax3l ax3l changed the title MPark.Variant [WIP] MPark.Variant Feb 16, 2018
C0nsultant
C0nsultant approved these changes Feb 16, 2018
View reviewed changes
Copy link
Member

@C0nsultant C0nsultant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the dependency is still not nice to have, it's worth it for getting Boost out of the system earlier.

@ax3l
Copy link
Member Author

ax3l commented Feb 16, 2018

rebased the draft to not use git submodules but the single-header version.

we can later on do exactly the same for replacing boost test with the single-header catch2 library

@ax3l ax3l changed the title [WIP] MPark.Variant MPark.Variant Feb 16, 2018
ax3l and others added 4 commits February 16, 2018 15:09
@ax3l
boost::variant -> mpark::variant
bebe50a
@ax3l
MPark.Variant: CMake
1f79f1e
@mpark @ax3l
MPark.Variant: 1.3.0
c084426 
Add single-header version.
@ax3l
C++17: Use std::variant
cdc773f 
Do not use the MPark.Variant library if users compile with C++17
ax3l added 2 commits February 16, 2018 16:00
@ax3l
GenericPatchData: Add Src File
7cee114 
Missing source file added.
Missing includes added.
@ax3l
Fix Auxiliary Test
7c89020
@ax3l ax3l merged commit 69b3e0b into openPMD:dev Feb 16, 2018
@ax3l ax3l deleted the topic-variant branch February 16, 2018 15:26
@ax3l ax3l mentioned this pull request Feb 17, 2018
Merged
@C0nsultant
Copy link
Member

@ax3l TIL Quantstack uses this mpark::variant as well.

@ax3l
Copy link
Member Author

ax3l commented Feb 17, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0nsultant C0nsultant C0nsultant approved these changes

Assignees

@C0nsultant C0nsultant

Labels
discussion install refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ax3l @C0nsultant @mpark