Properly check for empty HDF5_VERSION in CMake #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old test apparently invoked some weird CMake legacy behavior. This should make the pinned HDF5 Conda version unnecessary (openPMD#1701) since the version with missing HDF5_VERSION is correctly dealt with.
franzpoeschel
force-pushed
the
hdf5-properly-deal-with-missing-version
branch
from
9ddf2c7 to
f9ae099
Compare
franzpoeschel
added a commit
to ax3l/openPMD-api
that referenced
this pull request
Dec 20, 2024
The old test apparently invoked some weird CMake legacy behavior. This should make the pinned HDF5 Conda version unnecessary (openPMD#1701) since the version with missing HDF5_VERSION is correctly dealt with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old test apparently invoked some weird CMake legacy behavior (and hence did not work). This should make the pinned HDF5 Conda version unnecessary (#1701) since the version with missing HDF5_VERSION is correctly dealt with.