openpmd-pipe: fix handling of constant components #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschnett
added a commit
to eschnett/openPMD-api
that referenced
this pull request
Oct 13, 2023
* dev: [pre-commit.ci] pre-commit autoupdate (openPMD#1536) Fix double mesh.read() call (openPMD#1535) Python 3.12: Remove Distutils (openPMD#1508) openpmd-pipe: fix handling of constant components (openPMD#1530) Bug fix: Linear read mode cannot directly access specific file of file-based Series (openPMD#1533) Unknown openPMD version in data: Add upgrade hint (openPMD#1528)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, the attributes
valueandshapewere written by the attribute cloning logic manually, and then again bymake_constant. This can cause issues in backends (especially ADIOS2) that only allow limited kinds of redefining attributes.