Python bindings: Release GIL during IO wait operations #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzpoeschel
commented
Feb 27, 2023
franzpoeschel
force-pushed
the
release-gil
branch
from
0b91fdd to
5838a01
Compare
franzpoeschel
force-pushed
the
release-gil
branch
from
5838a01 to
0d96819
Compare
eschnett
added a commit
to eschnett/openPMD-api
that referenced
this pull request
May 19, 2023
* dev: (82 commits) Docs: Linking to C++ Projects (openPMD#1445) CI: macOS-11 Update (openPMD#1446) [pre-commit.ci] pre-commit autoupdate (openPMD#1437) Fix deprecated storeChunk APIs in first read/write examples (openPMD#1435) Update .readthedocs.yml (openPMD#1438) Doc: Fix Bib Authors (openPMD#1434) [pre-commit.ci] pre-commit autoupdate (openPMD#1425) More careful documentation of streaming API (openPMD#1430) Fix gcc9 warning (openPMD#1429) Python bindings: Release GIL during IO wait operations (openPMD#1381) RecordComponent: Properly handle uninitialized datasets (openPMD#1316) Remove ADIOS1 - Long Live ADIOS2 (openPMD#1419) Post 0.15.0 Changelog Template (openPMD#1420) GitHub Actions: macOS has 3 Cores (openPMD#1421) `version.hpp`: 0.15.1 (openPMD#1417) [pre-commit.ci] pre-commit autoupdate (openPMD#1416) Release 0.15.1 (openPMD#1414) Doc: More HTML Updates (CSS) (openPMD#1413) Enable clang-format also for .tpp files by using a regex instead of a predefined filter (openPMD#1403) Docs: Update Funding (openPMD#1412) ... # Conflicts: # .github/workflows/linux.yml # CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1380
This releases the GIL basically in those calls that trigger
adios2::Engine::BeginStep(). Releasing the GIL foradios2::Engine::EndStep, and during flushes is more difficult since those calls may imply write access to Python buffers.For a follow-up PR, we could try adding an
async forimplementation for theReadIterationsAPI.