Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] ADIOS2: Fix Parallel Resize #1126

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[WIP] ADIOS2: Fix Parallel Resize #1126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/ParallelIOTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ extendDataset( std::string const & ext )
std::iota( data2.begin(), data2.end(), 25 );
{
Series write( filename, Access::CREATE, MPI_COMM_WORLD );
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move the write below the return for ADIOS1?
Otherwise we create that empty ghost series.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit unfortunate, but we have to do it this way unfortunately, see write.backend() in the if condition. However, I can add a commit in #1043 that uses {"backend": "adios2"} to explicitly select backends up front.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added that commit

if( ext == "bp" && write.backend() != "ADIOS2" )
if( ext == "bp" && write.backend() != "MPI_ADIOS2" )
{
// dataset resizing unsupported in ADIOS1
return;
Expand Down