Replace Boost.Test with Catch2 #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
added
tests
install
third party
ax3l
changed the title
ax3l
changed the title
Also shipped internally (but not needed during runtime, so not installed).
If testing is disabled in CMake, there is no need to - require Catch2 - build the tests - register `make test`
C0nsultant
reviewed
Apr 5, 2018
| @@ -563,6 +579,7 @@ message("") | |||
| message(" Additionally installed third party libraries:") | |||
| invertBoolean(openPMD_USE_INTERNAL_VARIANT openPMD_HAVE_EXTERNAL_VARIANT) | |||
| message(" MPark.Variant: ${openPMD_HAVE_EXTERNAL_VARIANT}") | |||
| message(" Catch2: OFF") | |||
There was a problem hiding this comment.
Should this do the same inversion as the lines above with openPMD_USE_INTERNAL_CATCH?
There was a problem hiding this comment.
Good question! No, Catch2 will not be installed on make install simply because it is only needed at build-time.
There was a problem hiding this comment.
It took me a while to get the intent of the messages.
That is a really elegant and clever solution and makes the Variant output really useful.
C0nsultant
approved these changes
Apr 5, 2018
Use sane defaults to reduce noise, keep ignoring C++98 compat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace Boost.Test with Catch2.
Step toward #70 and #86