Add header for openPMD-specific errors #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzpoeschel
force-pushed
the
error-class
branch
from
cf6ac65 to
5ac6c17
Compare
This was referenced Aug 5, 2021
Merged
franzpoeschel
force-pushed
the
error-class
branch
from
fa51db0 to
2ffe0c4
Compare
franzpoeschel
force-pushed
the
error-class
branch
from
2ffe0c4 to
280bd03
Compare
ax3l
reviewed
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just the scaffolding for the more fine-grained error-handling that we want to implement.
This adds:
openPMD::Errorwhich should serve as base class for all of openPMD's error types. It should not be instatiated directly, but via child classes.openPMD::errorwhich bundles all those error types.openPMD::error::OperationUnsupportedInBackend, without using it.Related: #983 (this is not a fix, but the fundament for a fix)
TODO: