Cleanup

openPMD · Dec 13, 2024 · 8c02519 · 8c02519
1 parent 01cf39b
commit 8c02519
Show file tree

Hide file tree

Showing 2 changed files with 192 additions and 90 deletions.
diff --git a/include/openPMD/RecordComponent.tpp b/include/openPMD/RecordComponent.tpp
@@ -125,6 +125,10 @@ RecordComponent::loadChunk(std::shared_ptr<T> data, Offset o, Extent e)
     /*
      * For constant components, we implement type conversion, so there is
      * a separate check further below.
+     * This is especially useful for the short-attribute representation in the
+     * JSON/TOML backends as they might implicitly turn a LONG into an INT in a
+     * constant component. The frontend needs to catch such edge cases.
+     * Ref. `if (constant())` branch.
      */
     if (dtype != getDatatype() && !constant())
         if (!isSameInteger<T>(getDatatype()) &&