Add forgotten H5Aclose() call

openPMD · Dec 4, 2024 · 6ee8426 · 6ee8426
1 parent 84b8d83
commit 6ee8426
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/IO/HDF5/HDF5IOHandler.cpp b/src/IO/HDF5/HDF5IOHandler.cpp
@@ -1739,6 +1739,12 @@ void HDF5IOHandlerImpl::writeAttribute(
             "during attribute write");
         if (equal == 0) // unequal
         {
+            status = H5Aclose(attribute_id);
+            VERIFY(
+                status == 0,
+                "[HDF5] Internal error: Failed to close previous HDF5 "
+                "attribute "
+                "during attribute write");
             status = H5Adelete(node_id, name.c_str());
             VERIFY(
                 status == 0,

diff --git a/test/SerialIOTest.cpp b/test/SerialIOTest.cpp
@@ -7571,9 +7571,6 @@ void groupbased_read_write(std::string const &ext)
         read.close();
     }
 
-    return;
-    std::cout << "Now truncate " << filename << std::endl;
-
     // check that truncation works correctly
     {
         Series write(filename, Access::CREATE);