Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRI acquisition type #487

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

Peyman-N
Copy link
Member

@Peyman-N Peyman-N commented Feb 6, 2025

Adding MRI acquisition type to controlled terms.
Derived from DICOM tag (0018,0023):
Instances:

  • 1D

  • 2D
    frequency x phase

  • 3D
    frequency x phase x phase

Copy link
Member

@lzehl lzehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Peyman-N I don't have a strong opinion here. Is MR acquisition type more used than MRI acquisition mode ?

@Peyman-N
Copy link
Member Author

Peyman-N commented Feb 7, 2025

@lzehl Sorry, I thought I had changed all of them to acquisition type. Originally, after our meeting, I wanted to name it mode, but then I reviewed the literature and they are almost always acquisition type.

@Peyman-N Peyman-N changed the title MRI acquisition mode MRI acquisition type Feb 7, 2025
@Peyman-N Peyman-N requested a review from lzehl February 7, 2025 12:42
@lzehl
Copy link
Member

lzehl commented Feb 10, 2025

@Peyman-N please add also the terminology instance for this new controlledTerms schemas

@lzehl lzehl merged commit 7803046 into openMetadataInitiative:v3 Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants