fix#1250 passcode verification implemented #1251
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devansh-299
force-pushed
the
fix#1250
branch
from
57d96bc
to
0f5482c
Compare
luckyman20
reviewed
Dec 15, 2019
app/src/main/java/org/mifos/mobile/ui/fragments/TransferProcessFragment.java
Outdated
Show resolved
Hide resolved
devansh-299
force-pushed
the
fix#1250
branch
from
0f5482c
to
c45b334
Compare
luckyman20
requested changes
Dec 31, 2019
app/src/main/java/org/mifos/mobile/ui/activities/TransferVerificationActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/activities/TransferVerificationActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/activities/TransferVerificationActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/activities/TransferVerificationActivity.java
Outdated
Show resolved
Hide resolved
devansh-299
force-pushed
the
fix#1250
branch
from
c45b334
to
86ec147
Compare
|
@luckyman20 I have made the requested changes . Thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1250
Screenrecording
Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.