Fix #990: Adding Reports field and preventing crash #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@therajanmaurya @tarun0 Please review |
AkshGautam
force-pushed
the
client_report
branch
4 times, most recently
from
b865995 to
ef781fb
Compare
AkshGautam
force-pushed
the
client_report
branch
from
ef781fb to
52bbb9e
Compare
AkshGautam
force-pushed
the
client_report
branch
3 times, most recently
from
6c731cf to
9421675
Compare
AkshGautam
force-pushed
the
client_report
branch
2 times, most recently
from
6b94301 to
14f2d59
Compare
AkshGautam
force-pushed
the
client_report
branch
from
14f2d59 to
3c2657a
Compare
tarun0
previously requested changes
Oct 4, 2018
| toolbar.addView(spinner); | ||
| intent = new Intent("report"); |
There was a problem hiding this comment.
Don't use any Action like this. From the documentation :
Note that the action must be in a namespace because Intents are used globally in the system -- for example the system VIEW action is android.intent.action.VIEW; an application's custom action would be something like com.google.app.myapp.CUSTOM_ACTION
| @@ -60,6 +74,7 @@ public static ClientReportCategoryFragment newInstance() { | |||
| public void onCreate(Bundle savedInstanceState) { | |||
| super.onCreate(savedInstanceState); | |||
| ((MifosBaseActivity) getActivity()).getActivityComponent().inject(this); | |||
| getActivity().registerReceiver(this.broadCastNewMessage, new IntentFilter("report")); | |||
There was a problem hiding this comment.
It'll be better to keep this action too in the Constants file.
| <string name="savings_acc_deposit">SavingsAccDeposit</string> | ||
| <string name="glaccount">GLAccountNO</string> | ||
| <string name="obligation_date_type">Obligation date type</string> | ||
| <string name="start_date">Start Date</string> |
There was a problem hiding this comment.
Please verify if these are already not present. There are chances that these may already be used somewhere. Ignore if they are not present earlier.
AkshGautam
force-pushed
the
client_report
branch
from
3c2657a to
09bbfe2
Compare
AkshGautam
force-pushed
the
client_report
branch
from
09bbfe2 to
8f24fb5
Compare
therajanmaurya
dismissed
tarun0’s stale review
Aksh Made the changes. I am merging the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #990
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.