fix #987:Enhancing the document upload and identifier dialog #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@therajanmaurya @tarun0 please review
|
AkshGautam
force-pushed
the
dialog_enhancements
branch
from
8effd41 to
3abf186
Compare
AkshGautam
changed the title
therajanmaurya
requested changes
Jun 11, 2018
| @@ -67,6 +67,9 @@ | |||
| @BindView(R.id.tv_choose_file) | |||
| TextView tv_choose_file; | |||
|
|
|||
| @BindView(R.id.btn_browse_document) | |||
| Button bt_browse; | |||
There was a problem hiding this comment.
Please follow the camel case naming convention
There was a problem hiding this comment.
@therajanmaurya snake case convention is followed across the entire document. For example : tv_choose_file,et_document_description
There was a problem hiding this comment.
@therajanmaurya done
AkshGautam
force-pushed
the
dialog_enhancements
branch
2 times, most recently
from
8c7de88 to
b1e5f6f
Compare
AkshGautam
force-pushed
the
dialog_enhancements
branch
from
b1e5f6f to
9b69d98
Compare
therajanmaurya
approved these changes
Aug 15, 2018
This was referenced Jan 17, 2019
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #987
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.