Fix Issue #859:Disabled menu item on selection #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tarun0 @therajanmaurya Please review this for issue #859 . I have tried to reduce the function calls and checked it to verify that it's working in all cases like back button press etc. |
AkshGautam
changed the title
|
A fix engendering another issue isn't quite a 'fix' :) Two progressbars are being shown simultaneously in the video you attached. |
tarun0
reviewed
Feb 14, 2018
| @@ -63,6 +63,7 @@ | |||
| SwitchCompat userStatusToggle; | |||
| private Menu menu; | |||
| private boolean doubleBackToExitPressedOnce = false; | |||
| private boolean item_client = true, item_center = true, item_group = true; | |||
There was a problem hiding this comment.
Follow camelCase naming convention.
AkshGautam
force-pushed
the
onclicked
branch
from
7f55415 to
af83fe9
Compare
|
@tarun0 @therajanmaurya I have made the changes. Please ignore the two progress bars since it is already a persisting issue which I have already solved in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #476
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.