fix: The progress bar in Datatables of both Clients and Groups loads endlessly.

[AbhilashG97]

Please make sure these boxes are checked before submitting your pull request - thanks!

• Apply the MifosStyle.xml style template to your code in Android Studio.

• Run the unit tests with ./gradlew check to make sure you didn't break anything

• If you have multiple commits please combine them into one commit by squashing them.

Issue Reference :
#597

After fixing the issue-
The progress bar now doesn't load endlessly on going back from a Datatable to the list of Datatables.

[AbhilashG97]

I have made the required changes, please review my pull request. And kindly let me know if I have to make any further changes.

[therajanmaurya]

@AbhilashG97 Can you please remove this line ((MifosBaseActivity) getActivity()).getActivityComponent().inject(this); to public View onCreateView() from public void onCreate() and Let me know what happen.

[AbhilashG97]

@therajanmaurya, I made the suggested change, and there seems to be no difference in the behavior of the datatables, the endless loading is still not present, as expected. I am attaching the GIF of the application after I made the suggested change. The logs for the same can be found here. Also, should I apply these changes in the pull request ? Kindly let me know.

[therajanmaurya]

Do one more thing, instead of initializing the subscriptions = new CompositeSubscription(); in attachView, remove subscriptions.unsubscribe(); from detachView and add subscriptions.clear();.
Let me know.

[AbhilashG97]

@therajanmaurya, I have made the suggested changes, and the progress bar doesn't load endlessly. Please let me know if I have to make any further changes. GIF for the same can be found below.

GIF-