style: Incorrect error message is displayed in the Centers activity #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therajanmaurya
requested changes
Mar 14, 2017
| @@ -566,6 +566,7 @@ | |||
| <string name="failed_to_fetch_documents">Failed to fetch documents</string> | |||
| <string name="failed_to_fetch_groups">Failed to Fetch Groups</string> | |||
| <string name="failed_to_fetch_center">Failed to Fetch Center</string> | |||
| <string name="failed_to_fetch_centers">Failed to Fetch Centers</string> | |||
There was a problem hiding this comment.
Remove this string and refactor the above string with same name and value.
AbhilashG97
force-pushed
the
android-client-574
branch
from
cf165af to
1f0b8ea
Compare
AbhilashG97
force-pushed
the
android-client-574
branch
from
1f0b8ea to
c225dde
Compare
|
@therajanmaurya , I have made the requested changes, kindly let me know if I have to make any further changes. |
droidchef
approved these changes
Mar 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.