Fixes #1654 layout enhancements in item_individiual_collection_sheet.xml #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+31
to
+34
| android:layout_marginLeft="@dimen/layout_padding_16dp" | ||
| android:layout_marginStart="@dimen/layout_padding_16dp" | ||
| android:layout_marginTop="@dimen/layout_padding_16dp" | ||
| android:layout_marginBottom="@dimen/layout_padding_16dp" /> |
There was a problem hiding this comment.
Suggested change
| android:layout_marginLeft="@dimen/layout_padding_16dp" | |
| android:layout_marginStart="@dimen/layout_padding_16dp" | |
| android:layout_marginTop="@dimen/layout_padding_16dp" | |
| android:layout_marginBottom="@dimen/layout_padding_16dp" /> | |
| android:layout_margin="@dimen/layout_padding_16dp/>" |
@danishjamal104 If possible please reduce it to only single line attribute layout_margin that might reduce redundancies and save 3 more lines.
Rest all looks good
There was a problem hiding this comment.
If we use margin as a single attribute then it will apply a margin to all 4 sides but I need to apply a margin to all sides except the right or end that's why I defined all three.
|
@danishjamal104 I think this time you forgot to write issue number in heading, if possible please update it too :) |
danishjamal104
changed the title
Done, thanks @PatelVatsalB21 for pointing that out. :) |
iamsh4shank
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1654
Please Add Screenshots If there are any UI changes.
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.