Fixes #1588 Auto search added when user add filter in searchFragment #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robustTechie please review the changes And suggested if any. Thanks :) |
danishjamal104
changed the title
iamsh4shank
approved these changes
Dec 3, 2020
Thanks @robustTechie :) |
This was referenced Jan 29, 2021
iamsh4shank
requested changes
Jul 17, 2021
There was a problem hiding this comment.
Hey @danishjamal104 can you fix the merge request so that we could merge it soon :)
Sure |
iamsh4shank
approved these changes
Jul 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1588
Changes
SearchFragment.javafile.autoTriggerSearchto determine whether a click is called by user or user this is used for determining whether a toast is needed to be displayed or not in case of the empty search string.onClickSearchinsideonItemSelectedScreenshot
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.