Fixes #1562 UI improvements in client details page #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danishjamal104
force-pushed
the
ui-improvements-client-info
branch
from
209ed33 to
caefc4a
Compare
iamsh4shank
requested changes
Jun 1, 2021
done with the changes, please check. |
iamsh4shank
requested changes
Jun 2, 2021
danishjamal104
force-pushed
the
ui-improvements-client-info
branch
2 times, most recently
from
caefc4a to
415bb6b
Compare
|
@iamsh4shank kindly merge this. Thanks :) |
|
@danishjamal104 can you fix the build fail so that I will merge it asap |
danishjamal104
force-pushed
the
ui-improvements-client-info
branch
3 times, most recently
from
a879031 to
9304ba0
Compare
danishjamal104
force-pushed
the
ui-improvements-client-info
branch
from
9304ba0 to
bcfdc5a
Compare
The build is passing successfully on my local machine but failing on the travis, see below two screen shot @iamsh4shank. Thanks :)Travis Screenshot of error Local build screen shot of task:mifosng-android:pmd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1562
Changes
round_table_row_bg.xmlfor rounded corners in a table row.Accountsheader to separate the client info table and accounts elements.Screenshot
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.