Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add message to progress dialogs #1224

Merged
merged 1 commit into from
Dec 16, 2019
Merged

Fix: add message to progress dialogs #1224

merged 1 commit into from
Dec 16, 2019

Conversation

OHassini
Copy link
Contributor

@OHassini OHassini commented Dec 9, 2019

Fixes #1223

Please Add Screenshots If there are any UI changes.

I updated all the progress dialogues not showing messages and here's a sample of them :

Screenshot_20191209-212142

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the MifosStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@OHassini
Copy link
Contributor Author

OHassini commented Dec 9, 2019

@luckyman20 @elirehema, @moksh-mahajan @santoshconflux Hi : ), please have a look at this

@OHassini
Copy link
Contributor Author

OHassini commented Dec 10, 2019

@luckyman20 Hi : ), ProgressDialogues are not actual AlertDialogues they just extend the AlertDialogue class so they don't completely work like alertDialogues that's why both progress and alert dialogues have different methods of creation, the alertDialogue lets you use its Builder class to connect all the sets without a problem but unfortunately the progressDialogue doesn't have its own Builder class it just uses the one of the AlertDialogue(that can only return an alertDialogue instance creating in that case an "incompatible types" error), that's why the correct way of initializing a progressDialogue is by using separate sets and that's also the method used in the progressDialogue class and in the other constructor method of the SafeUIBlockingUtility class.

@luckyman20 luckyman20 changed the title Fix #1223 - Fixes progress dialogues don't show a message Fix: add message to progress dialogs Dec 11, 2019
Copy link
Collaborator

@luckyman20 luckyman20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@OHassini
Copy link
Contributor Author

@luckyman20 Done !!

@OHassini
Copy link
Contributor Author

@moksh-mahajan Hi : ), please have a look at this.

Copy link
Collaborator

@luckyman20 luckyman20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@luckyman20 luckyman20 merged commit 42d0422 into openMF:master Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some progress dialogues don't show a message
3 participants