-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: add message to progress dialogs #1224
Conversation
@luckyman20 @elirehema, @moksh-mahajan @santoshconflux Hi : ), please have a look at this |
mifosng-android/src/main/java/com/mifos/utils/SafeUIBlockingUtility.java
Show resolved
Hide resolved
@luckyman20 Hi : ), ProgressDialogues are not actual AlertDialogues they just extend the AlertDialogue class so they don't completely work like alertDialogues that's why both progress and alert dialogues have different methods of creation, the alertDialogue lets you use its Builder class to connect all the sets without a problem but unfortunately the progressDialogue doesn't have its own Builder class it just uses the one of the AlertDialogue(that can only return an alertDialogue instance creating in that case an "incompatible types" error), that's why the correct way of initializing a progressDialogue is by using separate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@luckyman20 Done !! |
@moksh-mahajan Hi : ), please have a look at this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Fixes #1223
Please Add Screenshots If there are any UI changes.
I updated all the progress dialogues not showing messages and here's a sample of them :
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xml
style template to your code in Android Studio.Run the unit tests with
./gradlew check
to make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.