fix: maker checker condition handling #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this looks like an interesting fix, good work @laxyapahuja! |
|
@moksh-mahajan @elirehema @luckyman20 can you please review this task? :D |
|
LGTM. Good Job @laxyapahuja |
moksh-mahajan
approved these changes
Dec 9, 2019
|
will this get merged? @luckyman20 |
luckyman20
reviewed
Dec 25, 2019
...src/main/java/com/mifos/mifosxdroid/online/datatablelistfragment/DataTableListPresenter.java
Outdated
Show resolved
Hide resolved
Added a test to check if the client created is actually active or not. The app shows toast accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1181
When Maker Checker is enabled:
When Maker Checker is disabled:
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.