Feat: Added Checker Inbox feature #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moksh-mahajan
force-pushed
the
CheckerInboxAndroidXTemp2
branch
2 times, most recently
from
f00cd6b to
331bd27
Compare
moksh-mahajan
changed the title
tarun0
requested changes
Aug 27, 2019
| @@ -4,6 +4,7 @@ | |||
| */ | |||
|
|
|||
| buildscript { | |||
| ext.kotlin_version = "1.3.31" | |||
There was a problem hiding this comment.
Please make a separate PR for Kotlin support.
| super.onCreate(savedInstanceState) | ||
| actionOptionsList = mutableListOf() | ||
| entityOptionsList = mutableListOf() | ||
| actionOptionsList.add("ALL") |
There was a problem hiding this comment.
Make some constant(s) for these types. It'll make it convenient for developers to makes changes later.
| } | ||
|
|
||
| override fun onError(e: Throwable) { | ||
|
|
moksh-mahajan
force-pushed
the
CheckerInboxAndroidXTemp2
branch
from
331bd27 to
6b0385e
Compare
moksh-mahajan
force-pushed
the
CheckerInboxAndroidXTemp2
branch
from
6b0385e to
a8c6c42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Apply the
MifosStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.